Skip to content

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented Jun 10, 2025

counterpart of deltachat/deltachat-ios#2638

@adbenitez adbenitez requested a review from r10s June 10, 2025 13:21
@adbenitez

This comment was marked as outdated.

@adbenitez
Copy link
Member Author

the dialog that appears when inviting someone says that you need to have an app installed, we probably need a new string

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s
Copy link
Member

r10s commented Jun 12, 2025

the dialog that appears when inviting someone says that you need to have an app installed, we probably need a new string

for now, we can just not use the string videochat_invite_user_hint

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great that you figured out all that!

if needed, we can merge that roughly as is to move forward.

the only thing we should necessarily change is to not show the call option by default, maybe we need a switch for that, as we introduced a default string, but any other way that comes in mind would do as well

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s r10s mentioned this pull request Jun 20, 2025
@adbenitez adbenitez marked this pull request as draft August 18, 2025 12:32
@adbenitez adbenitez added enhancement actually in development, user visible enhancement wait-for-core Issue/PR is waiting for core release labels Aug 18, 2025
@adbenitez adbenitez self-assigned this Aug 18, 2025
@r10s r10s added this to Calls Aug 19, 2025
@r10s r10s moved this to In Progress in Calls Aug 19, 2025
@r10s r10s mentioned this pull request Aug 26, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement wait-for-core Issue/PR is waiting for core release
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants