-
-
Notifications
You must be signed in to change notification settings - Fork 173
improve the videocalls: open in internal webview #3785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
src/main/java/org/thoughtcrime/securesms/videochat/VideochatUtil.java
Outdated
Show resolved
Hide resolved
the dialog that appears when inviting someone says that you need to have an app installed, we probably need a new string |
To test the changes in this pull request, install this apk: |
for now, we can just not use the string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great that you figured out all that!
if needed, we can merge that roughly as is to move forward.
the only thing we should necessarily change is to not show the call option by default, maybe we need a switch for that, as we introduced a default string, but any other way that comes in mind would do as well
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
counterpart of deltachat/deltachat-ios#2638