drop disappearing messages options 1 and 30 minutes #3897
Merged
+19
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR drop disappearing messages options for 1 and 30 minutes:
with the recent change to start the timer when the chat is opened, one minute is too easy too short to miss important information
"30 minutes" does not really fit into the distribution; all other option have at least the factor 5 to the previous one, from "30 minutes" to "60 minutes", the time is doubled only.
removing the overall number of options and dropping the ones without larger usecases, does not only simplifies UI;
having less tiny details also reduces noise in groups where ppl people changing it very often for various weird reasons (found the latter point somewhere in the Signal forum, btw)
this is a successor of the "added 1 year option", by that, apart form the "5 minutes", we are also very close to "delete old messages".
came over that when thinking deltachat/deltachat-pages#1172 over.