Fixes for READ_MULTIPLE and WRITE_MULTIPLE commands #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(necessary but not sufficient for getting 9.2 to boot again on the Beige G3, see Discord discussion) |
We may be transferring less data than can fit in a chunk, so we need to ensure that xfer_cnt is clamped to 0 when transferring the last chunk (otherwise it remains negative, and has_data() will return true). It's also possible that the transfer size is bigger than a chunk but not an even multiple of the chunk size, so we need to ensure that we don't try to transfer a whole chunk in the last iteration. More correctly initialize the device identification struct, to report the maximum (word 47) and current (word 59) number of blocks that can be transferred with READ_MULTIPLE and WRITE_MULTIPLE commands. Fix post_xfer_action to write the actual data size that was written, as opposed to an entire chunk (which may be larger).
mihaip
force-pushed
the
upstream-multiple
branch
from
7e9ab83 to
52f4d84
Compare
|
Did another round of fixes, 9.2 now boots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may be transferring less data than can fit in a chunk, so we need to ensure that
xfer_cntis clamped to 0 when transferring the last chunk (otherwise it remains negative, andhas_data()will return true).It's also possible that the transfer size is bigger than a chunk but not an even multiple of the chunk size, so we need to ensure that we don't try to transfer a whole chunk in the last iteration.
More correctly initialize the device identification struct, to report the maximum (word 47) and current (word 59) number of blocks that can be transferred with
READ_MULTIPLEandWRITE_MULTIPLEcommands.Fix
post_xfer_actionto write the actual chunk size that was written, as opposed to an entire chunk (which may be larger).