Skip to content

refactor: avoid capturing this in delegate using local self pointer #10821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gorsing
Copy link

@gorsing gorsing commented Jul 21, 2025

To avoid implicit capturing of this in a delegate,
replaced direct field access with access via a local pointer self cast to Impl*.

Old similar and alternative #10816

This is a preventive fix for a potential Phobos error related to delegate lifetime,
as seen in: dlang/dmd#21514

No functional behavior change is intended.

@gorsing gorsing requested a review from CyberShadow as a code owner July 21, 2025 11:20
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @gorsing! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10821"

@0xEAB
Copy link
Member

0xEAB commented Jul 24, 2025

Thanks for your contribution, @gorsing :)

Would you mind adding a unittest that showcases the advantage of this change? (Assuming that this is possible. If not, don’t bother.) Doing so could also potentially prevent accidental breakage caused by future changes.

@gorsing
Copy link
Author

gorsing commented Aug 4, 2025

@0xEAB Changes aimed at eliminating leaks in closures
The behavior has not changed.
Unfortunately, I haven’t been able to come up with a visual test yet.
Perhaps dlang/dmd#21514 will be adopted in some form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants