enhancing search field functionality #242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-allowing search on blank prompt -recording user text in lastUserText -enhancing auto text preview to match popup -adding common auto complete by tab click -fixing search thread safety issues -only setting "newItem" property once per operation rather than twice for clearer eventing -removing search delay now that search is thread safe -fixing left right arrow actions in the search field editor -fix new item producer usages
|
Just seeing this, is this typical? I only see pre-existing javadocs formatting warnings in the build failure. |
…ance-search-field
…ance-search-field
|
@dlemmermann let me know if there are issues with the changes I make here. As far as I can tell from your demos and my usages these are only enhancements, but I can adjust the changes if there are situations this is not viable for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-not showing search while history popup is visible
-allowing search on blank prompt
-recording user text in lastUserText
-enhancing auto text preview to match popup
-adding common auto complete by tab click
-fixing search thread safety issues
-only setting "newItem" property once per operation rather than twice for clearer eventing
-removing search delay now that search is thread safe
-fixing left right arrow actions in the search field editor
-fix new item producer usages