Use enum values from enumType in DiscriminatorColumn and check DiscriminatorMap values against it #11804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unsure where to go from here. It seems to me tests are failing on platforms with no native enum support. |
No, the tests are failing on DBAL versions without |
Unfortunately I'm out of ideas how to proceed from here. :) |
…nto fix-enum-discriminator-column
whataboutpereira
force-pushed
the
fix-enum-discriminator-column
branch
from
d699266 to
0f11930
Compare
|
Okay, got the history cleaned up now. |
|
Auto closed due deleting the base branch or is there still hope to get something like this in? |
|
Sorry, it was closed because I deleted the branch. Feel free to reopen against another branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #11794.
Currently the values of enumType in DiscriminatorColumn are ignored which results in an error when generating a migration:
Fixed by populating values from the enum and also prevent invalid entries in DiscriminatorMap.