[PHP8.4]private(set) properties should be skipped to avoid resetting values #11872
Conversation
|
|
||
| #[ORM\Entity] | ||
| #[ORM\Table(name: 'DDC11871_Order')] | ||
| class DDC11871Order |
There was a problem hiding this comment.
Please inline the classes into the Test or create a new modelset.
There was a problem hiding this comment.
Inlining classes makes tests with PHP < 8.4 failling. What do you mean by "create a new modelset"?
| if (version_compare(PHP_VERSION, '8.4', '<')) { | ||
| continue; | ||
| } elseif ($property->isPrivateSet() === false) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This logic looks wrong, it only skips private set fields in PHP 8.4+ - but not others anymore.
Should maybe be:
if ($property->isStatic() || (($class->hasField($name) || $class->hasAssociation($name)) && ! isset($identifiers[$name])) || (PHP_VERSION_ID >= 80400 && $property->isPrivateSet())) {
continue;
}There was a problem hiding this comment.
I'll try to write a test making sure which properties are skipped. I'll get back to you shortly.
|
I think similar to property hooks, use of We need to write a positive test, probably only working in conjunction with #11853 . before allowing use. |
Do you have any estimate to have property hook ready to deploy ? |
Ignore phpcs validation as it doesn't support property(set) yet.
|
This skip will break lazy loading, accessing a private set property would not trigger ir |
|
Can you try if this issue exists when using the dev version of var-exporter? |
|
@nicolas-grekas Works fine with 7.2x-dev and 7.3.x-dev 😃 |
Attempt to fix issue #11871
Summary : When an entity is associated with a class declaring private(set) properties. The proxyFactory does not ignore those properties as it does with privates one. This leads to an error such as "Error: Cannot unset private(set) property ".