Feature: add support for ColocatedMappingDriver::$filePaths
#12106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Aug 5, 2025
composer.json
Outdated
| @@ -37,6 +37,7 @@ | |||
| "symfony/var-exporter": "^6.3.9 || ^7.0" | |||
| }, | |||
| "require-dev": { | |||
| "doctrine/persistence": "^3.3.1 || ^4.0 || 4.1.x-dev", | |||
There was a problem hiding this comment.
We should keep this MR in draft status until this can be reverted.
There was a problem hiding this comment.
By the way, I've noticed that doctrine/DoctrineBundle has "minimum-stability": "dev", which makes possible the installation of dev versions of packages that match the constraint ("doctrine/persistence": "^3.1 || ^4" used there acquires 4.1.x-dev).
There was a problem hiding this comment.
We have a CI job that tests against unstable packages (mostly Symfony). I think, you can just add Persitence there. It makes sense to test against dev versions of Persistence.
There was a problem hiding this comment.
Do you mean to adjust phpunit-smoke-check to include persistence version 4.1-dev?
|
@derrabus since you suggested this approach, I'm requesting your review specifically |
rela589n
force-pushed
the
feat-attribute-driver-iterable-files
branch
7 times, most recently
from
684dbc0 to
8794b18
Compare
derrabus
reviewed
Aug 7, 2025
rela589n
force-pushed
the
feat-attribute-driver-iterable-files
branch
3 times, most recently
from
44d4b45 to
35699bf
Compare
rela589n
added a commit
to rela589n/DoctrineBundle
that referenced
this pull request
Aug 7, 2025
This commit adds support for a `$pathsAsFilePaths` parameter, introduced as part of doctrine/orm#12106 It adds a minor BC break (as well as was in the case of `$reportFieldsWhereDeclared` - `8d8579`) - classes, extending `DoctrineOrmMappingsPass` that override `createAttributeMappingDriver()` method will face signature mismatch.
rela589n
force-pushed
the
feat-attribute-driver-iterable-files
branch
from
35699bf to
df8ddf9
Compare
rela589n
changed the title
ColocatedMappingDriver::$filePaths
In the scope of doctrine/persistence#432 (available from `doctrine/persistence` >= 4.1) there was added `ColocatedMappingDriver::$filePaths` property, which allows passing the iterable of file paths for the mapping driver to use. This commit integrates those changes into `AttributeDriver`. Since `doctrine/orm` maintains the support for `doctrine/persistence` of older versions, `AttributeDriver` ensures that `$filePaths` is actually defined. Tests use `InstalledVersions` to opt into new behaviour if `doctrine/persistence` is version 4.1 or above. The old behaviour can be adapted into the new by using `DirectoryFilesIterator` and `FilePathNameIterator` on directory paths.
rela589n
force-pushed
the
feat-attribute-driver-iterable-files
branch
from
df8ddf9 to
dbad9e2
Compare
rela589n
added a commit
to rela589n/DoctrineBundle
that referenced
this pull request
Aug 12, 2025
This commit adds support for a `$pathsAsFilePaths` parameter, introduced as part of doctrine/orm#12106 It adds a minor BC break (as well as was in the case of `$reportFieldsWhereDeclared` - `8d8579`) - classes, extending `DoctrineOrmMappingsPass` that override `createAttributeMappingDriver()` method will face signature mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced add support for
ColocatedMappingDriver::$filePaths, fromdoctrine/persistence>= 4.1 (doctrine/persistence#432). Sincedoctrine/ormmaintains the support fordoctrine/persistenceof older versions,AttributeDriverensures that$filePathsis actually defined. Tests useInstalledVersionsto opt into new behavior ifdoctrine/persistenceis at least version 4.1. The old behaviour can be adapted into the new by usingDirectoryFilesIteratorandFilePathNameIteratoron directory paths.