add sync to close, disconnect, and flush #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync
suffix to close, disconnect, and flush methods that can perform significant work:_sync
suffix to corresponding bindings functions:The implementation of these functions is unchanged.
In the future, I plan to add async versions of all of these, using the name without the
Sync
or_sync
suffix. Releasing this name change separately from adding the async versions hopefully make migration easier, because the name change will be detected by the compiler, while changing a function from sync to async is harder to detect.