Support PG18 beta1 #788
Merged
Support PG18 beta1 #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps it needs to be modified like this Line 16 in 49cd676 #ifdef PG_MODULE_MAGIC_EXT
PG_MODULE_MAGIC_EXT(.name = "pg_duckdb", .version = "1.0.0");
#else
PG_MODULE_MAGIC;
#endif |
Done by taking the diff for PG17 ruleutils, manually changing 17 to 18 in there everywhere and then applying: To get the diff: ``` git diff e963297 src/vendor/pg_ruleutils_17.c > ruleutils.diff ``` To apply: ``` git apply --3way ruleutils.diff ```
JelteF
added a commit
that referenced
this pull request
Jun 24, 2025
Things that this does to make PG18 work: - Add a bunch of `#if PG_VERSION_NUM` cases for function calls with additional/fewer arguments. - Refactor explain logic to a separate file in `src/pg` because they require include new different headers. - Adds a wrapper to handle differences in C locale checking across versions - Use `TupleDescAttr` instead of manually indexing into the `attrs` array. PG18 doesn't use this attrs array anymore. - Start using `PG_MODULE_MAGIC_EXT`, it's easy and allows people to inspect the version of the shared library.
JelteF
added a commit
that referenced
this pull request
Jun 24, 2025
Things that this does to make PG18 work: - Add a bunch of `#if PG_VERSION_NUM` cases for function calls with additional/fewer arguments. - Refactor explain logic to a separate file in `src/pg` because they require include new different headers. - Adds a wrapper to handle differences in C locale checking across versions - Use `TupleDescAttr` instead of manually indexing into the `attrs` array. PG18 doesn't use this attrs array anymore. - Start using `PG_MODULE_MAGIC_EXT`, it's easy and allows people to inspect the version of the shared library.
Things that this does to make PG18 work: - Add a bunch of `#if PG_VERSION_NUM` cases for function calls with additional/fewer arguments. - Refactor explain logic to a separate file in `src/pg` because they require include new different headers. - Adds a wrapper to handle differences in C locale checking across versions - Use `TupleDescAttr` instead of manually indexing into the `attrs` array. PG18 doesn't use this attrs array anymore. - Start using `PG_MODULE_MAGIC_EXT`, it's easy and allows people to inspect the version of the shared library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some of the initial to support PG18 beta1. It definitely needs another self-review, but seems good to at least put it in a draft PR.