Don't call into the Postgres planner anymore when we take over #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
In the past we needed to call into the Postgres planner for permission checking on Postgres tables. This has not been needed for a while now. We were still doing it out of caution for breaking other things, but it seems like that might be causing problems by itself too. And also it's quite a waste of CPU cycles.
JelteF
force-pushed
the
remove-additional-planner-call
branch
from
64ff71e to
59d5179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we needed to call into the Postgres planner for permission checking on Postgres tables. This has not been needed for a while now. We were still doing it out of caution for breaking other things, but it seems like calling standard_planner might be causing problems by itself too (see #845). Furthermore calling the regular planner is also quite a waste of CPU cycles.