Change duckdb.max_memory/duckdb.memory_limit to integer GUC
#883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This PR breaks using 'GiB' as unit and only allows units such as 'MB', 'GB'. |
I think that's fine. Can you update the tests accordingly. |
|
Checked Bug #879 - looks good now. |
JelteF
reviewed
Aug 13, 2025
| select * from duckdb.query($$ select current_setting('memory_limit') $$); | ||
| current_setting('memory_limit') | ||
| --------------------------------- | ||
| 1.0 GiB | ||
| (1 row) | ||
|
|
||
| CALL duckdb.recycle_ddb(); | ||
| set duckdb.memory_limit = ''; |
There was a problem hiding this comment.
Can we allow setting this to -1 or something to represent the "duckdb default"?
There was a problem hiding this comment.
Setting the value to 0 will use the 'DuckDB default'. It appears that DuckDB determines this default by checking the system spec. I removed this case since it may lead to unstable case.
JelteF
approved these changes
Aug 15, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #879