Skip to content

Tag pixel owners on pixel validation reports in Asana #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2025

Conversation

jeannamatthews
Copy link
Contributor

Reviewer:

Description:

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jeannamatthews jeannamatthews self-assigned this Aug 15, 2025
@jeannamatthews jeannamatthews requested a review from Copilot August 15, 2025 18:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to tag pixel owners on pixel validation reports in Asana by introducing a new configuration flag. The change enables automatic tagging of pixel owners when validation reports are generated, improving notification coverage for relevant stakeholders.

  • Adds tagPixelOwners configuration flag to enable owner tagging functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jeannamatthews jeannamatthews requested a review from nshuba August 15, 2025 18:06
Copy link
Contributor

@nshuba nshuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after duckduckgo/pixel-schema#34 is merged

@jeannamatthews jeannamatthews merged commit eec96b7 into main Aug 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants