Skip to content

Schema coverage #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Schema coverage #3519

wants to merge 3 commits into from

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Jul 31, 2025

Asana Task/Github Issue:

Description

Adds a basic report npm run schema-coverage that we can use to prioritise schema writing need/risk.
Not enforced and intended to be short lived poorly written script.

image

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@jonathanKingston jonathanKingston changed the title Jkt/schema coverage Schema coverage Jul 31, 2025
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions github-actions bot requested a review from bwaresiak July 31, 2025 10:28
@jonathanKingston jonathanKingston marked this pull request as ready for review July 31, 2025 10:28
@jonathanKingston jonathanKingston requested review from a team as code owners July 31, 2025 10:28
Copy link

github-actions bot commented Jul 31, 2025

Generated file outputs:

Time updated: Thu, 31 Jul 2025 10:29:33 GMT

legacy
29 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

latest
14 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

Copy link

github-actions bot commented Jul 31, 2025

🔴 BETA JSON approval analysis:

Time updated: Thu, 31 Jul 2025 10:29:33 GMT

latest

🎯 OVERALL APPROVAL STATUS

✅ AUTO-APPROVED

github-actions bot pushed a commit that referenced this pull request Jul 31, 2025
github-actions bot pushed a commit that referenced this pull request Jul 31, 2025
}

// Run the analysis
if (import.meta.url === `file://${process.argv[1]}`) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Script Execution Check Fails with Relative Paths

The condition import.meta.url === file://${process.argv[1]}``, intended to check for direct script execution, fails because import.meta.url is an absolute file URL while `process.argv[1]` can be a relative path. This prevents the script's main `analyzeSchemaCoverage()` function from running when executed with a relative path (e.g., `node scripts/schema-coverage-report.mjs`) or via an npm script.

Locations (1)
Fix in Cursor Fix in Web

if (override.features) {
for (const featureName of Object.keys(override.features)) {
// Convert camelCase to kebab-case for matching
const kebabName = camelToKebab(featureName);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: PascalCase Strings Incorrectly Prefixed

The camelToKebab function incorrectly adds a leading dash to PascalCase strings (e.g., "SomeFeature" becomes "-some-feature"). This causes getPlatformSpecificFeatures to store platform-specific feature names with an incorrect leading dash in its internal map. As feature names extracted from JSON and schema files do not have this leading dash, it results in mismatches and inaccurate detection of platform-specific features.

Locations (1)
Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants