Skip to content

[DO NOT MERGE] Enable Privacy Pro Rebranding #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Aug 12, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211009668282867?focus=true

Description

Added FFs for enabling privacy pro rebranding

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@nalcalag nalcalag requested review from a team as code owners August 12, 2025 09:25
@nalcalag nalcalag added the DO NOT MERGE Don't merge this branch unless directed label Aug 12, 2025
@nalcalag nalcalag requested a review from a team as a code owner August 12, 2025 09:25
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Tue, 12 Aug 2025 09:26:34 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/android-config.json
  • v4/android-config.json
--- v4/android-config.json (and 1 other files)
+++ v4/android-config.json
@@ -43552,8 +43552,14 @@
                             "name": "treatment",
                             "weight": 1
                         }
                     ]
+                },
+                "subscriptionRebranding": {
+                    "state": "enabled"
+                },
+                "subscriptionAIFeaturesRebranding": {
+                    "state": "enabled"
                 }
             }
         },
         "privacyProtectionsPopup": {
latest
v5/android-config.json
--- v5/android-config.json
+++ v5/android-config.json
@@ -43552,8 +43552,14 @@
                             "name": "treatment",
                             "weight": 1
                         }
                     ]
+                },
+                "subscriptionRebranding": {
+                    "state": "enabled"
+                },
+                "subscriptionAIFeaturesRebranding": {
+                    "state": "enabled"
                 }
             }
         },
         "privacyProtectionsPopup": {
13 files identical
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

Copy link

🔴 BETA JSON approval analysis:

Time updated: Tue, 12 Aug 2025 09:26:35 GMT

legacy

❌ Manual Review Required

  • v3/android-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/subscriptionAIFeaturesRebranding (add)
    • /features/privacyPro/features/subscriptionRebranding (add)
  • v4/android-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/subscriptionAIFeaturesRebranding (add)
    • /features/privacyPro/features/subscriptionRebranding (add)
latest

❌ Manual Review Required

  • v5/android-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/privacyPro/features/subscriptionAIFeaturesRebranding (add)
    • /features/privacyPro/features/subscriptionRebranding (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

github-actions bot pushed a commit that referenced this pull request Aug 12, 2025
@github-actions github-actions bot requested a review from lmac012 August 12, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this branch unless directed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants