-
Notifications
You must be signed in to change notification settings - Fork 95
Clean up defaultBrowserPrompts remote config feature and add the new flag for defaultBrowserPrompts25 #3615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.
👉 Please mark this as DRAFT unless there's an intention to merge this immediately. |
Generated file outputs:Time updated: Tue, 26 Aug 2025 10:10:37 GMT legacy27 files identical
2 files changed
--- v4/android-config.json (and 1 other files)
+++ v4/android-config.json
@@ -37903,37 +37903,28 @@
},
"exceptions": []
},
"defaultBrowserPrompts": {
- "state": "disabled",
+ "state": "enabled",
"exceptions": [],
"features": {
- "defaultBrowserAdditionalPrompts202501": {
- "state": "disabled",
- "minSupportedVersion": 52282000,
- "settings": {
- "activeDaysUntilStage1": "1",
- "activeDaysUntilStage2": "4",
- "activeDaysUntilStop": "11"
+ "defaultBrowserPrompts25": {
+ "state": "enabled",
+ "minSupportedVersion": 52451000,
+ "rollout": {
+ "steps": [
+ {
+ "percent": 5
+ }
+ ]
},
- "cohorts": [
- {
- "name": "control",
- "weight": 0
- },
- {
- "name": "variant1",
- "weight": 0
- },
- {
- "name": "variant2",
- "weight": 0
- },
- {
- "name": "variant3",
- "weight": 0
- }
- ]
+ "settings": {
+ "newUserActiveDaysUntilStage1": "1",
+ "newUserActiveDaysUntilStage2": "5",
+ "newUserActiveDaysUntilStage3": "19",
+ "existingUserActiveDaysUntilStage1": "0",
+ "existingUserActiveDaysUntilStage3": "14"
+ }
}
}
},
"delayedWebviewPresentation": {
latestv5/android-config.json--- v5/android-config.json
+++ v5/android-config.json
@@ -37903,37 +37903,28 @@
},
"exceptions": []
},
"defaultBrowserPrompts": {
- "state": "disabled",
+ "state": "enabled",
"exceptions": [],
"features": {
- "defaultBrowserAdditionalPrompts202501": {
- "state": "disabled",
- "minSupportedVersion": 52282000,
- "settings": {
- "activeDaysUntilStage1": "1",
- "activeDaysUntilStage2": "4",
- "activeDaysUntilStop": "11"
+ "defaultBrowserPrompts25": {
+ "state": "enabled",
+ "minSupportedVersion": 52451000,
+ "rollout": {
+ "steps": [
+ {
+ "percent": 5
+ }
+ ]
},
- "cohorts": [
- {
- "name": "control",
- "weight": 0
- },
- {
- "name": "variant1",
- "weight": 0
- },
- {
- "name": "variant2",
- "weight": 0
- },
- {
- "name": "variant3",
- "weight": 0
- }
- ]
+ "settings": {
+ "newUserActiveDaysUntilStage1": "1",
+ "newUserActiveDaysUntilStage2": "5",
+ "newUserActiveDaysUntilStage3": "19",
+ "existingUserActiveDaysUntilStage1": "0",
+ "existingUserActiveDaysUntilStage3": "14"
+ }
}
}
},
"delayedWebviewPresentation": {
13 files identical
|
🔴 BETA JSON approval analysis:Time updated: Tue, 26 Aug 2025 10:10:37 GMT legacy❌ Manual Review Required
latest❌ Manual Review Required
🎯 OVERALL APPROVAL STATUS❌ MANUAL REVIEW REQUIRED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1142021229838617/task/1209626585877656?focus=true
Description
Cleaned up
defaultBrowserPrompts
and addeddefaultBrowserPrompts25
.Both are enabled, rollout set to 5%, min version for
defaultBrowserPrompts25
is next Android version5.245.0
.Feature change process:
Site breakage mitigation process:
Brief explanation