Skip to content

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Aug 19, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1142021229838617/task/1209626585877656?focus=true

Description

Cleaned up defaultBrowserPrompts and added defaultBrowserPrompts25.
Both are enabled, rollout set to 5%, min version for defaultBrowserPrompts25 is next Android version 5.245.0.

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@anikiki anikiki requested review from a team as code owners August 19, 2025 13:32
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@anikiki anikiki added the DO NOT MERGE Don't merge this branch unless directed label Aug 19, 2025
Copy link

github-actions bot commented Aug 19, 2025

Generated file outputs:

Time updated: Tue, 26 Aug 2025 10:10:37 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/android-config.json
  • v4/android-config.json
--- v4/android-config.json (and 1 other files)
+++ v4/android-config.json
@@ -37903,37 +37903,28 @@
             },
             "exceptions": []
         },
         "defaultBrowserPrompts": {
-            "state": "disabled",
+            "state": "enabled",
             "exceptions": [],
             "features": {
-                "defaultBrowserAdditionalPrompts202501": {
-                    "state": "disabled",
-                    "minSupportedVersion": 52282000,
-                    "settings": {
-                        "activeDaysUntilStage1": "1",
-                        "activeDaysUntilStage2": "4",
-                        "activeDaysUntilStop": "11"
+                "defaultBrowserPrompts25": {
+                    "state": "enabled",
+                    "minSupportedVersion": 52451000,
+                    "rollout": {
+                        "steps": [
+                            {
+                                "percent": 5
+                            }
+                        ]
                     },
-                    "cohorts": [
-                        {
-                            "name": "control",
-                            "weight": 0
-                        },
-                        {
-                            "name": "variant1",
-                            "weight": 0
-                        },
-                        {
-                            "name": "variant2",
-                            "weight": 0
-                        },
-                        {
-                            "name": "variant3",
-                            "weight": 0
-                        }
-                    ]
+                    "settings": {
+                        "newUserActiveDaysUntilStage1": "1",
+                        "newUserActiveDaysUntilStage2": "5",
+                        "newUserActiveDaysUntilStage3": "19",
+                        "existingUserActiveDaysUntilStage1": "0",
+                        "existingUserActiveDaysUntilStage3": "14"
+                    }
                 }
             }
         },
         "delayedWebviewPresentation": {
latest
v5/android-config.json
--- v5/android-config.json
+++ v5/android-config.json
@@ -37903,37 +37903,28 @@
             },
             "exceptions": []
         },
         "defaultBrowserPrompts": {
-            "state": "disabled",
+            "state": "enabled",
             "exceptions": [],
             "features": {
-                "defaultBrowserAdditionalPrompts202501": {
-                    "state": "disabled",
-                    "minSupportedVersion": 52282000,
-                    "settings": {
-                        "activeDaysUntilStage1": "1",
-                        "activeDaysUntilStage2": "4",
-                        "activeDaysUntilStop": "11"
+                "defaultBrowserPrompts25": {
+                    "state": "enabled",
+                    "minSupportedVersion": 52451000,
+                    "rollout": {
+                        "steps": [
+                            {
+                                "percent": 5
+                            }
+                        ]
                     },
-                    "cohorts": [
-                        {
-                            "name": "control",
-                            "weight": 0
-                        },
-                        {
-                            "name": "variant1",
-                            "weight": 0
-                        },
-                        {
-                            "name": "variant2",
-                            "weight": 0
-                        },
-                        {
-                            "name": "variant3",
-                            "weight": 0
-                        }
-                    ]
+                    "settings": {
+                        "newUserActiveDaysUntilStage1": "1",
+                        "newUserActiveDaysUntilStage2": "5",
+                        "newUserActiveDaysUntilStage3": "19",
+                        "existingUserActiveDaysUntilStage1": "0",
+                        "existingUserActiveDaysUntilStage3": "14"
+                    }
                 }
             }
         },
         "delayedWebviewPresentation": {
13 files identical
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

Copy link

github-actions bot commented Aug 19, 2025

🔴 BETA JSON approval analysis:

Time updated: Tue, 26 Aug 2025 10:10:37 GMT

legacy

❌ Manual Review Required

  • v3/android-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/defaultBrowserPrompts/state (replace)
    • /features/defaultBrowserPrompts/features/defaultBrowserAdditionalPrompts202501 (remove)
    • /features/defaultBrowserPrompts/features/defaultBrowserPrompts25 (add)
  • v4/android-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/defaultBrowserPrompts/state (replace)
    • /features/defaultBrowserPrompts/features/defaultBrowserAdditionalPrompts202501 (remove)
    • /features/defaultBrowserPrompts/features/defaultBrowserPrompts25 (add)
latest

❌ Manual Review Required

  • v5/android-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/defaultBrowserPrompts/state (replace)
    • /features/defaultBrowserPrompts/features/defaultBrowserAdditionalPrompts202501 (remove)
    • /features/defaultBrowserPrompts/features/defaultBrowserPrompts25 (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

github-actions bot pushed a commit that referenced this pull request Aug 19, 2025
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcosholgado
marcosholgado previously approved these changes Aug 19, 2025
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now :D

github-actions bot pushed a commit that referenced this pull request Aug 26, 2025
@anikiki anikiki assigned marcosholgado and unassigned anikiki Aug 26, 2025
@github-actions github-actions bot requested a review from marcosholgado August 26, 2025 10:36
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anikiki anikiki added this pull request to the merge queue Aug 26, 2025
Merged via the queue into main with commit 3cecd58 Aug 26, 2025
15 of 17 checks passed
@anikiki anikiki deleted the feature/ana/clean_up_defaultbrowserprompts_remote_config_feature_and_add_the_new_flag_for_defaultbrowserprompts25 branch August 26, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this branch unless directed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants