Skip to content

Add config limits #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2025
Merged

Add config limits #3626

merged 5 commits into from
Aug 28, 2025
+339 −0

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Aug 21, 2025 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1200890834746050/task/1209336318923191?focus=true

Description

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@github-actions GitHub Actions
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

github-actions bot pushed a commit that referenced this pull request Aug 21, 2025
@actions-user
Publish config for PR #3626
86776ad
@github-actions GitHub Actions
Copy link

🔗 Preview Config for PR #3626

Last updated: 2025-08-21 18:20:17 UTC

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

❌ Generated diff output is too large to post as a comment, run locally to see the diff and validate

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

🔴 BETA JSON approval analysis:

Time updated: Thu, 21 Aug 2025 20:41:47 GMT

legacy

❌ Manual Review Required

  • v3/ios-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/autoconsent/settings/compactRuleList2 (add)
    • /features/autoconsent/settings/disabledCMPs2 (add)
    • /features/autoconsent/settings/filterlistExceptions2 (add)
  • v3/macos-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/autoconsent/settings/compactRuleList2 (add)
    • /features/autoconsent/settings/disabledCMPs2 (add)
    • /features/autoconsent/settings/filterlistExceptions2 (add)
  • v3/windows-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/autoconsent/settings/compactRuleList2 (add)
    • /features/autoconsent/settings/disabledCMPs2 (add)
    • /features/autoconsent/settings/filterlistExceptions2 (add)
  • v4/ios-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/autoconsent/settings/compactRuleList2 (add)
    • /features/autoconsent/settings/disabledCMPs2 (add)
    • /features/autoconsent/settings/filterlistExceptions2 (add)
  • v4/macos-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/autoconsent/settings/compactRuleList2 (add)
    • /features/autoconsent/settings/disabledCMPs2 (add)
    • /features/autoconsent/settings/filterlistExceptions2 (add)
  • v4/windows-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/autoconsent/settings/compactRuleList2 (add)
    • /features/autoconsent/settings/disabledCMPs2 (add)
    • /features/autoconsent/settings/filterlistExceptions2 (add)
latest

❌ Manual Review Required

  • v5/ios-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/autoconsent/settings/compactRuleList2 (add)
    • /features/autoconsent/settings/disabledCMPs2 (add)
    • /features/autoconsent/settings/filterlistExceptions2 (add)
  • v5/macos-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/autoconsent/settings/compactRuleList2 (add)
    • /features/autoconsent/settings/disabledCMPs2 (add)
    • /features/autoconsent/settings/filterlistExceptions2 (add)
  • v5/windows-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/autoconsent/settings/compactRuleList2 (add)
    • /features/autoconsent/settings/disabledCMPs2 (add)
    • /features/autoconsent/settings/filterlistExceptions2 (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

@github-actions GitHub Actions
Copy link

🔗 Preview Config for PR #3626

Last updated: 2025-08-21 18:28:23 UTC

github-actions bot pushed a commit that referenced this pull request Aug 21, 2025
@actions-user
Publish config for PR #3626
cc71758
@github-actions GitHub Actions
Copy link

🔗 Preview Config for PR #3626

Last updated: 2025-08-21 18:34:48 UTC

github-actions bot pushed a commit that referenced this pull request Aug 21, 2025
@actions-user
Publish config for PR #3626
55e463b
@github-actions GitHub Actions
Copy link

🔗 Preview Config for PR #3626

Last updated: 2025-08-21 18:42:24 UTC

github-actions bot pushed a commit that referenced this pull request Aug 21, 2025
@actions-user
Publish config for PR #3626
cc76d98
@jonathanKingston jonathanKingston marked this pull request as ready for review August 21, 2025 19:05
@jonathanKingston jonathanKingston requested review from a team as code owners August 21, 2025 19:05
@github-actions GitHub Actions
Copy link

🔗 Preview Config for PR #3626

Last updated: 2025-08-21 19:05:58 UTC

github-actions bot pushed a commit that referenced this pull request Aug 21, 2025
@actions-user
Publish config for PR #3626
aedf527
@github-actions github-actions bot requested a review from dharb August 21, 2025 19:06
jonathanKingston
jonathanKingston commented Aug 25, 2025
View reviewed changes
@dharb dharb disabled auto-merge August 25, 2025 20:06
dharb
dharb approved these changes Aug 25, 2025
View reviewed changes
Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good check to have in place and code looks 👍 . Basing the check on the current autoconsent config size (as of today) is a bit arbitrary, but I trust your judgment.

Think we should document this somewhere so people aren't surprised and confused if they hit this failure, or do you think the test itself is enough documentation?

@jonathanKingston
Copy link
Collaborator Author

Gonna merge this, anyone hitting it will know about it already. Can course correct if/when stuff happens.

Seems like a good check to have in place and code looks 👍 . Basing the check on the current autoconsent config size (as of today) is a bit arbitrary, but I trust your judgment.

It's just a know problem area, so a forcing function to that growth.

@jonathanKingston jonathanKingston added this pull request to the merge queue Aug 28, 2025
Merged via the queue into main with commit e492ad3 Aug 28, 2025
23 checks passed
@jonathanKingston jonathanKingston deleted the jkt/config-limits branch August 28, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharb dharb dharb approved these changes

Assignees

@dharb dharb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @dharb