Skip to content

Conversation

tomasstrba
Copy link
Contributor

@tomasstrba tomasstrba commented Aug 22, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1148564399326804/task/1211123676044316?focus=true

Description

  1. Omnibar subfeature set to internal for macOS
  2. New subfeature for independent New Tab Page instance per tab

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@tomasstrba tomasstrba requested review from a team as code owners August 22, 2025 13:52
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

github-actions bot pushed a commit that referenced this pull request Aug 22, 2025
Copy link

github-actions bot commented Aug 22, 2025

Generated file outputs:

Time updated: Fri, 22 Aug 2025 13:56:28 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

26 files changed
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/windows-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/windows-config.json
--- v4/windows-config.json (and 25 other files)
+++ v4/windows-config.json
@@ -102268,8 +102268,11 @@
                     "state": "enabled"
                 },
                 "omnibar": {
                     "state": "internal"
+                },
+                "newTabPagePerTab": {
+                    "state": "disabled"
                 }
             },
             "minSupportedVersion": "0.100.0"
         },
2 files changed
  • v3/macos-config.json
  • v4/macos-config.json
--- v4/macos-config.json (and 1 other files)
+++ v4/macos-config.json
@@ -102424,9 +102424,12 @@
                 "nextStepsWidget": {
                     "state": "disabled"
                 },
                 "omnibar": {
-                    "state": "disabled"
+                    "state": "internal"
+                },
+                "newTabPagePerTab": {
+                    "state": "internal"
                 }
             },
             "minSupportedVersion": "1.125.0"
         },
latest
13 files changed
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/windows-config.json
--- v5/windows-config.json (and 12 other files)
+++ v5/windows-config.json
@@ -102268,8 +102268,11 @@
                     "state": "enabled"
                 },
                 "omnibar": {
                     "state": "internal"
+                },
+                "newTabPagePerTab": {
+                    "state": "disabled"
                 }
             },
             "minSupportedVersion": "0.100.0"
         },
v5/macos-config.json
--- v5/macos-config.json
+++ v5/macos-config.json
@@ -102424,9 +102424,12 @@
                 "nextStepsWidget": {
                     "state": "disabled"
                 },
                 "omnibar": {
-                    "state": "disabled"
+                    "state": "internal"
+                },
+                "newTabPagePerTab": {
+                    "state": "internal"
                 }
             },
             "minSupportedVersion": "1.125.0"
         },

Copy link

github-actions bot commented Aug 22, 2025

🔴 BETA JSON approval analysis:

Time updated: Fri, 22 Aug 2025 13:56:28 GMT

legacy

❌ Manual Review Required

  • v3/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-brave-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-bravemv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-chrome-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-chromemv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-edg-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-edge-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-edgmv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-firefox-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/extension-safarimv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/macos-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/omnibar/state (replace)
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v3/windows-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-brave-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-bravemv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-chrome-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-chromemv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-edg-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-edge-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-edgmv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-firefox-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/extension-safarimv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/macos-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/omnibar/state (replace)
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v4/windows-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
latest

❌ Manual Review Required

  • v5/android-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-brave-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-bravemv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-chrome-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-chromemv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-edg-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-edge-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-edgmv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-firefox-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/extension-safarimv3-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/macos-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/omnibar/state (replace)
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)
  • v5/windows-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/htmlNewTabPage/features/newTabPagePerTab (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

@tomasstrba tomasstrba requested a review from a team as a code owner August 22, 2025 13:55
github-actions bot pushed a commit that referenced this pull request Aug 22, 2025
@tomasstrba tomasstrba added this pull request to the merge queue Aug 26, 2025
Merged via the queue into main with commit 3358683 Aug 26, 2025
22 checks passed
@tomasstrba tomasstrba deleted the tom/new-tab-page-adjustments branch August 26, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants