Skip to content

Conversation

GuiltyDolphin
Copy link
Member

@GuiltyDolphin GuiltyDolphin requested review from a team as code owners August 25, 2025 13:51
@GuiltyDolphin GuiltyDolphin requested a review from graeme August 25, 2025 13:51
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

github-actions bot pushed a commit that referenced this pull request Aug 25, 2025
Copy link

Generated file outputs:

Time updated: Mon, 25 Aug 2025 13:52:27 GMT

legacy
23 files identical
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/windows-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/android-config.json
  • v4/android-config.json
--- v4/android-config.json (and 1 other files)
+++ v4/android-config.json
@@ -36893,21 +36893,21 @@
         "blockList": {
             "state": "enabled",
             "exceptions": [],
             "features": {
-                "tdsNextExperiment001": {
-                    "state": "disabled",
+                "tdsNextExperiment002": {
+                    "state": "enabled",
                     "minSupportedVersion": 52361000,
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 100
+                                "percent": 25
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v5/experiments/20250617-android-tds-control.json",
-                        "treatmentUrl": "v5/experiments/20250617-android-tds-treatment.json"
+                        "controlUrl": "v5/experiments/202508v1-android-tds-control.json",
+                        "treatmentUrl": "v5/experiments/202508v1-android-tds-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
2 files changed
  • v3/ios-config.json
  • v4/ios-config.json
--- v4/ios-config.json (and 1 other files)
+++ v4/ios-config.json
@@ -97225,20 +97225,20 @@
                     "domain": "noaprints.com"
                 }
             ],
             "features": {
-                "tdsNextExperimentJul25": {
-                    "state": "disabled",
+                "tdsNextExperiment002": {
+                    "state": "enabled",
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 100
+                                "percent": 25
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v5/experiments/20250617-ios-tds-control.json",
-                        "treatmentUrl": "v5/experiments/20250617-ios-tds-treatment.json"
+                        "controlUrl": "v5/experiments/202508v1-ios-tds-control.json",
+                        "treatmentUrl": "v5/experiments/202508v1-ios-tds-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
2 files changed
  • v3/macos-config.json
  • v4/macos-config.json
--- v4/macos-config.json (and 1 other files)
+++ v4/macos-config.json
@@ -97147,20 +97147,20 @@
                     "domain": "wjla.com"
                 }
             ],
             "features": {
-                "tdsNextExperimentAug25": {
-                    "state": "disabled",
+                "tdsNextExperiment002": {
+                    "state": "enabled",
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 100
+                                "percent": 25
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v6/experiments/20250623-macos-tds-control.json",
-                        "treatmentUrl": "v6/experiments/20250623-macos-tds-treatment.json"
+                        "controlUrl": "v6/experiments/202508v1-macos-tds-control.json",
+                        "treatmentUrl": "v6/experiments/202508v1-macos-tds-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
latest
v5/android-config.json
--- v5/android-config.json
+++ v5/android-config.json
@@ -36893,21 +36893,21 @@
         "blockList": {
             "state": "enabled",
             "exceptions": [],
             "features": {
-                "tdsNextExperiment001": {
-                    "state": "disabled",
+                "tdsNextExperiment002": {
+                    "state": "enabled",
                     "minSupportedVersion": 52361000,
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 100
+                                "percent": 25
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v5/experiments/20250617-android-tds-control.json",
-                        "treatmentUrl": "v5/experiments/20250617-android-tds-treatment.json"
+                        "controlUrl": "v5/experiments/202508v1-android-tds-control.json",
+                        "treatmentUrl": "v5/experiments/202508v1-android-tds-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
11 files identical
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/windows-config.json

⚠️ File is identical

v5/ios-config.json
--- v5/ios-config.json
+++ v5/ios-config.json
@@ -97225,20 +97225,20 @@
                     "domain": "noaprints.com"
                 }
             ],
             "features": {
-                "tdsNextExperimentJul25": {
-                    "state": "disabled",
+                "tdsNextExperiment002": {
+                    "state": "enabled",
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 100
+                                "percent": 25
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v5/experiments/20250617-ios-tds-control.json",
-                        "treatmentUrl": "v5/experiments/20250617-ios-tds-treatment.json"
+                        "controlUrl": "v5/experiments/202508v1-ios-tds-control.json",
+                        "treatmentUrl": "v5/experiments/202508v1-ios-tds-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
v5/macos-config.json
--- v5/macos-config.json
+++ v5/macos-config.json
@@ -97147,20 +97147,20 @@
                     "domain": "wjla.com"
                 }
             ],
             "features": {
-                "tdsNextExperimentAug25": {
-                    "state": "disabled",
+                "tdsNextExperiment002": {
+                    "state": "enabled",
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 100
+                                "percent": 25
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v6/experiments/20250623-macos-tds-control.json",
-                        "treatmentUrl": "v6/experiments/20250623-macos-tds-treatment.json"
+                        "controlUrl": "v6/experiments/202508v1-macos-tds-control.json",
+                        "treatmentUrl": "v6/experiments/202508v1-macos-tds-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",

Copy link

🔴 BETA JSON approval analysis:

Time updated: Mon, 25 Aug 2025 13:52:27 GMT

legacy

❌ Manual Review Required

  • v3/android-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/blockList/features/tdsNextExperiment001 (remove)
    • /features/blockList/features/tdsNextExperiment002 (add)
  • v3/ios-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperimentJul25 (remove)
    • /features/contentBlocking/features/tdsNextExperiment002 (add)
  • v3/macos-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperimentAug25 (remove)
    • /features/contentBlocking/features/tdsNextExperiment002 (add)
  • v4/android-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/blockList/features/tdsNextExperiment001 (remove)
    • /features/blockList/features/tdsNextExperiment002 (add)
  • v4/ios-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperimentJul25 (remove)
    • /features/contentBlocking/features/tdsNextExperiment002 (add)
  • v4/macos-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperimentAug25 (remove)
    • /features/contentBlocking/features/tdsNextExperiment002 (add)
latest

❌ Manual Review Required

  • v5/android-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/blockList/features/tdsNextExperiment001 (remove)
    • /features/blockList/features/tdsNextExperiment002 (add)
  • v5/ios-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperimentJul25 (remove)
    • /features/contentBlocking/features/tdsNextExperiment002 (add)
  • v5/macos-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/contentBlocking/features/tdsNextExperimentAug25 (remove)
    • /features/contentBlocking/features/tdsNextExperiment002 (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

@GuiltyDolphin GuiltyDolphin added this pull request to the merge queue Aug 26, 2025
Merged via the queue into main with commit b885eec Aug 26, 2025
21 checks passed
@GuiltyDolphin GuiltyDolphin deleted the gd-tds-aug branch August 26, 2025 10:59
"rollout": {
"steps": [
{
"percent": 100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that when we want to increase the percentage we need to add a step (not just increasing the number)
Just double checking cause here I see a single 100% step which doesn’t make sense….

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants