Add emailConfirmationDecoupling subfeature flag #3642
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.
👉 Please mark this as DRAFT unless there's an intention to merge this immediately. |
Generated file outputs:Time updated: Mon, 25 Aug 2025 21:08:19 GMT legacy25 files identical
4 files changed
--- v4/macos-config.json (and 3 other files)
+++ v4/macos-config.json
@@ -97470,8 +97470,11 @@
},
"remoteBrokerDelivery": {
"state": "enabled",
"minSupportedVersion": "1.140.0"
+ },
+ "emailConfirmationDecoupling": {
+ "state": "disabled"
}
},
"exceptions": [],
"minSupportedVersion": "1.70.0"
latest12 files identical
2 files changed
--- v5/macos-config.json (and 1 other files)
+++ v5/macos-config.json
@@ -97470,8 +97470,11 @@
},
"remoteBrokerDelivery": {
"state": "enabled",
"minSupportedVersion": "1.140.0"
+ },
+ "emailConfirmationDecoupling": {
+ "state": "disabled"
}
},
"exceptions": [],
"minSupportedVersion": "1.70.0"
|
🔴 BETA JSON approval analysis:Time updated: Mon, 25 Aug 2025 21:08:19 GMT legacy❌ Manual Review Required
latest❌ Manual Review Required
🎯 OVERALL APPROVAL STATUS❌ MANUAL REVIEW REQUIRED |
quanganhdo
force-pushed
the
anh/apple/pir-email-confirmation-decoupling
branch
from
0bef683 to
01c6477
Compare
jonathanKingston
approved these changes
Aug 27, 2025
rachelmcr
approved these changes
Aug 28, 2025
quanganhdo
added a commit
to duckduckgo/apple-browsers
that referenced
this pull request
Aug 28, 2025
<!-- Note: This template is a reminder of our Engineering Expectations and Definition of Done. Remove sections that don't apply to your changes.⚠️ If you're an external contributor, please file an issue before working on a PR. Discussing your changes beforehand will help ensure they align with our roadmap and that your time is well spent. --> Task/Issue URL: https://app.asana.com/1/137249556945/project/481882893211075/task/1211035673550926?focus=true Tech Design URL: https://app.asana.com/1/137249556945/task/1211049716064446 CC: @THISISDINOSAUR ### Description Adds `emailConfirmationDecoupling` subfeature flag and make it local overridable. Privacy config counterpart: duckduckgo/privacy-configuration#3642 ### Testing Steps <!-- Assume the reviewer is unfamiliar with this part of the app --> 1. CI passes 2. Use these as custom privacy config: `https://duckduckgo.github.io/privacy-configuration/pr-3642/v4/ios-config.json` for iOS and `https://duckduckgo.github.io/privacy-configuration/pr-3642/v4/macos-config.json` for macOS 3. Check Feature Flags override screen in Debug. `emailConfirmationDecoupling` should be `disabled` and overridable to `enabled`. ### Impact and Risks Low, no changed behavior in this particular PR. #### What could go wrong? <!-- Describe specific scenarios and how you've addressed them —> ### Quality Considerations <!— Focus on what matters for your changes: - What edge cases exist? - How does this affect performance? - What monitoring have you added? - What documentation needs updating? - How does this impact privacy/security? —> ### Notes to Reviewer <!-- Anything specific you want reviewers to focus on —> — ###### Internal references: [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f) | [Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) | [Tech Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/481882893211075/task/1211035673550926?focus=true
Tech design: https://app.asana.com/1/137249556945/project/1203581873609357/task/1211049716064446?focus=true
Description