Skip to content

Conversation

muodov
Copy link
Member

@muodov muodov commented Aug 27, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1203268166580279/task/1211149189357903?focus=true

see also: https://app.asana.com/1/137249556945/project/1203268166580279/task/1208104533693555

Description

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@muodov muodov requested review from sammacbeth and a team as code owners August 27, 2025 09:03
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Wed, 27 Aug 2025 09:04:15 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

14 files changed
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json (and 13 other files)
+++ v3/windows-config.json
@@ -474,12 +474,8 @@
                     "domain": "dailymail.co.uk",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2216"
                 },
                 {
-                    "domain": "dkb.de",
-                    "reason": "broken scrolling"
-                },
-                {
                     "domain": "headphonecheck.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2277"
                 },
                 {
14 files changed
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json (and 13 other files)
+++ v4/windows-config.json
@@ -405,11 +405,8 @@
                 {
                     "domain": "dailymail.co.uk"
                 },
                 {
-                    "domain": "dkb.de"
-                },
-                {
                     "domain": "headphonecheck.com"
                 },
                 {
                     "domain": "lehmannaudio.com"
latest
14 files changed
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json
  • v5/windows-config.json
--- v5/windows-config.json (and 13 other files)
+++ v5/windows-config.json
@@ -405,11 +405,8 @@
                 {
                     "domain": "dailymail.co.uk"
                 },
                 {
-                    "domain": "dkb.de"
-                },
-                {
                     "domain": "headphonecheck.com"
                 },
                 {
                     "domain": "lehmannaudio.com"

Copy link

🔴 BETA JSON approval analysis:

Time updated: Wed, 27 Aug 2025 09:04:15 GMT

latest

✅ Auto-Approved Files

  • v5/android-config.json (1 changes)
  • v5/extension-brave-config.json (1 changes)
  • v5/extension-bravemv3-config.json (1 changes)
  • v5/extension-chrome-config.json (1 changes)
  • v5/extension-chromemv3-config.json (1 changes)
  • v5/extension-config.json (1 changes)
  • v5/extension-edg-config.json (1 changes)
  • v5/extension-edge-config.json (1 changes)
  • v5/extension-edgmv3-config.json (1 changes)
  • v5/extension-firefox-config.json (1 changes)
  • v5/extension-safarimv3-config.json (1 changes)
  • v5/ios-config.json (1 changes)
  • v5/macos-config.json (1 changes)
  • v5/windows-config.json (1 changes)

🎯 OVERALL APPROVAL STATUS

✅ AUTO-APPROVED

github-actions bot pushed a commit that referenced this pull request Aug 27, 2025
@muodov muodov requested a review from laghee August 27, 2025 10:17
@muodov muodov added this pull request to the merge queue Aug 27, 2025
Merged via the queue into main with commit bb77a8c Aug 27, 2025
18 checks passed
@muodov muodov deleted the remove-dkb-mitigation branch August 27, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants