Skip to content

Conversation

jonathanKingston
Copy link
Collaborator

Asana Task/Github Issue:

Description

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@jonathanKingston jonathanKingston marked this pull request as ready for review August 28, 2025 21:59
@jonathanKingston jonathanKingston requested review from a team as code owners August 28, 2025 21:59
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

github-actions bot pushed a commit that referenced this pull request Aug 28, 2025
Copy link

Generated file outputs:

Time updated: Thu, 28 Aug 2025 22:00:20 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json

⚠️ File is identical

2 files changed
  • v3/windows-config.json
  • v4/windows-config.json
--- v4/windows-config.json (and 1 other files)
+++ v4/windows-config.json
@@ -97457,9 +97457,9 @@
                         "domain": "www.msn.com",
                         "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/139.0.0.0 Safari/537.36"
                     },
                     {
-                        "domain": "moneygram.com",
+                        "domain": "www.moneygram.com",
                         "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/139.0.0.0 Safari/537.36"
                     }
                 ],
                 "omitClientHintMutations": []
latest
13 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json

⚠️ File is identical

v5/windows-config.json
--- v5/windows-config.json
+++ v5/windows-config.json
@@ -97457,9 +97457,9 @@
                         "domain": "www.msn.com",
                         "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/139.0.0.0 Safari/537.36"
                     },
                     {
-                        "domain": "moneygram.com",
+                        "domain": "www.moneygram.com",
                         "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/139.0.0.0 Safari/537.36"
                     }
                 ],
                 "omitClientHintMutations": []

Copy link

🔴 BETA JSON approval analysis:

Time updated: Thu, 28 Aug 2025 22:00:51 GMT

legacy

❌ Manual Review Required

  • v3/windows-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/customUserAgent/settings/userAgentOverrides/2/domain (add)
    • /features/customUserAgent/settings/userAgentOverrides/2/userAgent (add)
    • /features/customUserAgent/settings/userAgentOverrides/1 (replace)
  • v4/windows-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/customUserAgent/settings/userAgentOverrides/2/domain (add)
    • /features/customUserAgent/settings/userAgentOverrides/2/userAgent (add)
    • /features/customUserAgent/settings/userAgentOverrides/1 (replace)
latest

❌ Manual Review Required

  • v5/windows-config.json (3 total changes)
    Disallowed paths that require review:
    • /features/customUserAgent/settings/userAgentOverrides/2/domain (add)
    • /features/customUserAgent/settings/userAgentOverrides/2/userAgent (add)
    • /features/customUserAgent/settings/userAgentOverrides/1 (replace)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

@jonathanKingston jonathanKingston added this pull request to the merge queue Aug 28, 2025
Merged via the queue into main with commit c402eb2 Aug 28, 2025
18 checks passed
@jonathanKingston jonathanKingston deleted the jonathanKingston-patch-1 branch August 28, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants