-
Notifications
You must be signed in to change notification settings - Fork 171
fix: Pantheon build fix #2950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pantheon build fix #2950
Conversation
…clipse-che#2935) * Update idea-ultimate.adoc * Update idea-ultimate.adoc * Update idea-ultimate.adoc * Update modules/end-user-guide/pages/idea-ultimate.adoc Co-authored-by: Ilya Buziuk <ibuziuk@redhat.com> --------- Co-authored-by: Ilya Buziuk <ibuziuk@redhat.com>
🎊 Navigate the preview: https://689ccb60f15fba44639b19b0--eclipse-che-docs-pr.netlify.app 🎊 |
|
||
[cols="1,1a,1a,1a"] | ||
|=== | ||
| IDE | Status | `__<editor_key>__` value | Note | ||
| IDE | Status | `__<editor_key>__` value | Note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| IDE | Status | `__<editor_key>__` value | Note | |
| IDE | Status | `editor_key` value | Note |
?
@@ -23,11 +23,11 @@ pass:c,a,q[{prod-url}]#__<git_repository_url>__?che-editor=__<editor_key>__ | |||
---- | |||
+ | |||
|
|||
.The URL parameter `__<editor_key>__` values for supported IDEs | |||
.The URL parameter `<editor_key>` values for supported IDEs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.The URL parameter `<editor_key>` values for supported IDEs | |
.The URL parameter `editor_key` values for supported IDEs |
why do we need <> here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it's a user replaced value. those are denoted by angle brackets
why there are 18 commits? |
it's a github error, the commits are empty and only the intended changes appear in the PR. but we could use this as an opportunity for Gaurav to start making contributions to the repo to get him started on his way to get merge rights. i can close this PR and ask him to create a new one with the same content. |
@deerskindoll yeah, let's have a single commit PR, but please review the formatting as well |
@gtrivedi88 alternatively, we could simply remove the angle brackets completely when referring to |
What does this pull request change?
Pantheon build is failing du to an XML issue that might be caused by angle brackets in a table
What issues does this pull request fix or reference?
Specify the version of the product this pull request applies to
main, 7.107, 7.104
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.