Skip to content

fix: Pantheon build fix #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from

Conversation

deerskindoll
Copy link
Contributor

What does this pull request change?

Pantheon build is failing du to an XML issue that might be caused by angle brackets in a table

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

main, 7.107, 7.104

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@deerskindoll deerskindoll requested a review from a team as a code owner August 13, 2025 17:23
@deerskindoll deerskindoll requested a review from tolusha August 13, 2025 17:23
Copy link

github-actions bot commented Aug 13, 2025

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Aug 13, 2025

🎊 Navigate the preview: https://689ccb60f15fba44639b19b0--eclipse-che-docs-pr.netlify.app 🎊


[cols="1,1a,1a,1a"]
|===
| IDE | Status | `__<editor_key>__` value | Note
| IDE | Status | `__&lt;editor_key&gt;__` value | Note
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| IDE | Status | `__&lt;editor_key&gt;__` value | Note
| IDE | Status | `editor_key` value | Note

?

@@ -23,11 +23,11 @@ pass:c,a,q[{prod-url}]#__<git_repository_url>__?che-editor=__<editor_key>__
----
+

.The URL parameter `__<editor_key>__` values for supported IDEs
.The URL parameter `<editor_key>` values for supported IDEs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.The URL parameter `<editor_key>` values for supported IDEs
.The URL parameter `editor_key` values for supported IDEs

why do we need <> here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's a user replaced value. those are denoted by angle brackets

@ibuziuk
Copy link
Member

ibuziuk commented Aug 14, 2025

why there are 18 commits?

@deerskindoll
Copy link
Contributor Author

why there are 18 commits?

it's a github error, the commits are empty and only the intended changes appear in the PR. but we could use this as an opportunity for Gaurav to start making contributions to the repo to get him started on his way to get merge rights. i can close this PR and ask him to create a new one with the same content.

@ibuziuk
Copy link
Member

ibuziuk commented Aug 14, 2025

@deerskindoll yeah, let's have a single commit PR, but please review the formatting as well

@deerskindoll
Copy link
Contributor Author

@gtrivedi88 alternatively, we could simply remove the angle brackets completely when referring to editor-key in the table because in that moment, it's not a user replaceable value. this might be simpler/clearer than replacing the < brackets with the alternative &lgt; characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants