fix(net.configuration): add missing 802.1X password field definition #10
Conversation
- Add CONFIG_802_1X_PASSWORD to NetworkConfigurationPropertyNames enum - Add password field definition to network configuration metadata - Ensures 802.1X authentication password field is properly exposed in configuration Signed-off-by: MMaiero <matteo.maiero@eurotech.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds the missing password field definition for 802.1X WiFi authentication that was referenced but not properly defined in the network configuration metadata.
- Added
CONFIG_802_1X_PASSWORDenum value toNetworkConfigurationPropertyNames - Added corresponding password field definition in
NetworkConfigurationServiceCommonwith proper password typing - Updated tests to validate the new configuration field and adjusted test counts
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| NetworkConfigurationPropertyNames.java | Adds the CONFIG_802_1X_PASSWORD enum constant |
| NetworkConfigurationServiceCommon.java | Implements the password field definition with proper Tscalar.PASSWORD typing |
| NetworkConfigurationMessagesBundle.properties | Adds localization string for the 802.1X password field |
| NMConfigurationServiceImplTest.java | Updates test count expectation to include the new field |
| NetworkConfigurationServiceCommonTest.java | Adds comprehensive test coverage for 802.1X password handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -10,6 +10,7 @@ | |||
| * Contributors: | |||
| * Eurotech | |||
| *******************************************************************************/ | |||
| // Content with portions generated by generative AI platform | |||
There was a problem hiding this comment.
Adding AI generation comments to existing files is not recommended as it doesn't accurately represent the contribution nature. This comment should either be removed or made more specific to only the lines that were actually AI-generated.
| // Content with portions generated by generative AI platform |
Copilot uses AI. Check for mistakes.
| @@ -10,6 +10,7 @@ | |||
| * Contributors: | |||
| * Eurotech | |||
| *******************************************************************************/ | |||
| // Content with portions generated by generative AI platform | |||
There was a problem hiding this comment.
Adding AI generation comments to existing files is not recommended as it doesn't accurately represent the contribution nature. This comment should either be removed or made more specific to only the lines that were actually AI-generated.
| // Content with portions generated by generative AI platform |
Copilot uses AI. Check for mistakes.
|
pierantoniomerlino
deleted the
fix/wifi-802-1x-password-field-definition
branch
Description
This PR fixes a missing configuration field for 802.1X WiFi authentication by adding the password field definition that was referenced but not properly defined in the network configuration metadata.
Changes Made
CONFIG_802_1X_PASSWORDenum value toNetworkConfigurationPropertyNamesNetworkConfigurationServiceCommonTscalar.PASSWORDfor secure handling