Skip to content

Conversation

daniel-weisse
Copy link
Member

Context

No reason to only run this once a week. Resources should be cleaned up as quick as possible

Proposed change(s)

  • Run clean up once a day
  • Don't abort a clean up run if a step fails, instead continue to the end
  • Clean up resources from release runs

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse requested a review from thomasten May 8, 2025 14:28
@daniel-weisse daniel-weisse added the no changelog Change won't be listed in release changelog label May 8, 2025
Copy link

netlify bot commented May 8, 2025

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 61f1849
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/681db64d794d600008ae139d

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Copy link
Member Author

I reduced the cleanup timeframe down to 4 days.
There is a quirk that can cause errors when trying to remove GCP resources after the IAM resources were already successfully removed.
This could lead to many cleanup runs with errors in that timeframe.
Since the job should now be a bit more reliable, I'll make sure to check the failure if anything does go wrong

@daniel-weisse daniel-weisse merged commit 823c891 into main May 9, 2025
6 checks passed
@daniel-weisse daniel-weisse deleted the dw/daily-cleanup branch May 9, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants