Switch to modern React contexts #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use React's context API to pass around instances of the API services for different components to use, but depended on React's original context API, which was deprecated 7 years ago. This switches to the new API. It's a little hacky -- the new API only allows class components to use a single context, when it would be nice to have separate contexts for the DB and local APIs. But we frequently use them together, so I just a single context that contains both.
Mr0grog
commented
Jun 13, 2025
| "ecmaVersion": 2020, | ||
| "ecmaVersion": 2022, |
There was a problem hiding this comment.
Honestly I think it would be fine to bring this up even farther! We haven’t refreshed things here in a long time. But this is the minimum needed for the syntax I wanted to leverage in this PR, and should be completely safe. Works both in Node 18 (we should also upgrade that) and all shipping browsers for a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use React's context API to pass around instances of the API services for different components to use, but depended on React's original context API, which was deprecated 7 years ago and was fully removed in React v19 last year. This switches to the new API. It's a little hacky: the new API only allows class components to use a single context, when it would be nice to have separate contexts for the DB and local APIs. But we frequently use them together, so I just a single context that contains both.