Drop babel-plugin-react-css-modules #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File-loader is deprecated and we no longer use it, but still had it hanging around as a dependency. This removes it and also updates postcss, since I am currently working in that area.
Also upgrade css-loader to the current release. Fixes #581.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the babel-plugin-react-css-modules package and instead uses css-loader directly to get CSS modules functionality. The Babel plugin provided some nice, convenient syntax, but hasn’t been well maintained. Its approach also causes frequent breakage because it needs to keep in sync with private aspects of css-loader, so I’ve dropped it instead of moving to a maintained fork, which works but has the same fundamental issues. See #581 for more discussion.
This also changes test snapshots slightly — with the Babel plugin, the selector re-naming is done by Babel and happens during tests. Without the Babel plugin, re-naming is done by Webpack, and does not actually run during Jest tests. So instead we have a little mock that just gives you back the selector name you asked for as a string.