Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few minor code changes needed for React 18 to work, and a lot of changes needed to keep tests working (most really have no major runtime impact, although a handful do probably make things slightly more robust).
A lot more stuff under the hood in React has become async, so a lot of these test changes are about timing and making sure a component fully renders and goes through its loading lifecycle (and cancels async API calls if the component is prematurely unloaded, as they are in some tests). Similarly, lots of test code also needed to now be wrapped in
act(() => (do a thing))
.I also updated some of the JS class syntax for a couple components that needed more invasive work for data/state loading while I was in there (for example,
diff-view.jsx
).