Skip to content

arm matrix #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

arm matrix #233

merged 1 commit into from
Nov 19, 2024

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 17, 2024

Having done some digging, the various wheels published to pypy don't include arm (Linux). This is my fault.

Looking at this example, it appears rather different than the documented change we made in #199.

Sorry about this @saulshanabrook. Hope this helps.

Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #233 will not alter performance

Comparing chayim:ck/eggies (15e7ddc) with main (f1fb5b4)

Summary

✅ 8 untouched benchmarks

@saulshanabrook saulshanabrook merged commit b3ead6f into egraphs-good:main Nov 19, 2024
9 checks passed
@saulshanabrook
Copy link
Member

Thanks for this!

Looks like there is an issue with the build, I tried to release this: https://github.com/egraphs-good/egglog-python/actions/runs/11917567163/job/33212959181

It might also be good to run the builds on all PRs not just releases to catch this kind of thing earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants