Skip to content

Enable walltime for codspeed #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 6, 2025
Merged

Enable walltime for codspeed #304

merged 6 commits into from
Jul 6, 2025

Conversation

saulshanabrook
Copy link
Member

Copy link

codspeed-hq bot commented Jul 5, 2025

CodSpeed WallTime Performance Report

Congrats! CodSpeed is installed 🎉

🆕 7 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_jit[add] (374.8 ms)
  • test_jit[lda] (8.4 s)
  • test_jit[tuple] (641.1 ms)
  • test_run_lda[array_api-optimized-numba] (111.1 µs)
  • test_run_lda[array_api-optimized] (781.1 µs)
  • test_run_lda[array_api] (4.4 ms)
  • test_run_lda[base] (2.1 ms)

@saulshanabrook
Copy link
Member Author

We should change this to run on both the normal and wall speed so we collect the other data as well. Also we could enable debug builds so debugging symbols are included.

https://github.com/orgs/community/discussions/50456

@saulshanabrook saulshanabrook requested a review from Copilot July 6, 2025 08:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enable walltime measurements by adding debug symbols to release builds and running benchmarks on both Codspeed and Ubuntu runners.

  • Un-comment and update release profile to include debug symbols
  • Introduce a matrix in the CI benchmark job to run on codspeed-macro and ubuntu-latest
  • Add a Cargo config to pass -g flag for debugging

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
Cargo.toml Enable debug symbols in the [profile.release] section
.github/workflows/CI.yml Parameterize the benchmark job with a runner matrix
.cargo/config.toml Configure global rustflags to include debug symbols
Comments suppressed due to low confidence (2)

.github/workflows/CI.yml:56

  • If codspeed-macro is a self-hosted runner label, you should include the self-hosted label as well (e.g., runs-on: ["self-hosted", "codspeed-macro"]) so the job can correctly target that runner.
        runner: [ codspeed-macro, ubuntu-latest ]

Cargo.toml:35

  • The debug field in [profile.release] typically expects an integer level (e.g., debug = 1); using a boolean may not be supported in all Cargo versions. Consider reverting to debug = 1 for broader compatibility.
debug = true

Copy link

codspeed-hq bot commented Jul 6, 2025

CodSpeed Instrumentation Performance Report

Merging #304 will not alter performance

Comparing saulshanabrook-patch-3 (6cabd54) with main (518ae60)

Summary

✅ 7 untouched benchmarks

@saulshanabrook saulshanabrook merged commit 8f61f9c into main Jul 6, 2025
29 of 30 checks passed
@saulshanabrook saulshanabrook deleted the saulshanabrook-patch-3 branch July 6, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant