-
Notifications
You must be signed in to change notification settings - Fork 14
Enable walltime for codspeed #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed WallTime Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
We should change this to run on both the normal and wall speed so we collect the other data as well. Also we could enable debug builds so debugging symbols are included. https://github.com/orgs/community/discussions/50456 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Enable walltime measurements by adding debug symbols to release builds and running benchmarks on both Codspeed and Ubuntu runners.
- Un-comment and update release profile to include debug symbols
- Introduce a matrix in the CI benchmark job to run on
codspeed-macro
andubuntu-latest
- Add a Cargo config to pass
-g
flag for debugging
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
Cargo.toml | Enable debug symbols in the [profile.release] section |
.github/workflows/CI.yml | Parameterize the benchmark job with a runner matrix |
.cargo/config.toml | Configure global rustflags to include debug symbols |
Comments suppressed due to low confidence (2)
.github/workflows/CI.yml:56
- If
codspeed-macro
is a self-hosted runner label, you should include theself-hosted
label as well (e.g.,runs-on: ["self-hosted", "codspeed-macro"]
) so the job can correctly target that runner.
runner: [ codspeed-macro, ubuntu-latest ]
Cargo.toml:35
- The
debug
field in[profile.release]
typically expects an integer level (e.g.,debug = 1
); using a boolean may not be supported in all Cargo versions. Consider reverting todebug = 1
for broader compatibility.
debug = true
CodSpeed Instrumentation Performance ReportMerging #304 will not alter performanceComparing Summary
|
https://codspeed.io/docs/instruments/walltime