Skip to content

Fix CodSpeed symbol resolution #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 8, 2025
Merged

Conversation

saulshanabrook
Copy link
Member

https://discord.com/channels/1065233827569598464/1391710232542973952/1391820740814438593

Hello!

Indeed there is a problem with symbol resolution during your benchmark execution.
Can you try by making two little tweaks ?

  1. Use the 3.6.1 codspeed action version that we have released today (which is not default with v3 because of a slight edge case that should not impact you)
    2.Could you also try to setup python by using
      - name: Set up Python
        uses: actions/setup-python@v5
        with:
          python-version-file: "pyproject.toml"

In your workflow ? As indicated by https://codspeed.io/docs/benchmarks/python#usage-with-uv

This helps by making sure we are able to resolve symbols used by the python build in order to build the profiling information.

Let me know if this does not solve the issue so we can continue looking into it!

Copy link

codspeed-hq bot commented Jul 8, 2025

CodSpeed WallTime Performance Report

Merging #306 will not alter performance

Comparing saulshanabrook-patch-3 (9f11237) with main (8f61f9c)

Summary

✅ 7 untouched benchmarks

Copy link

codspeed-hq bot commented Jul 8, 2025

CodSpeed Instrumentation Performance Report

Merging #306 will not alter performance

Comparing saulshanabrook-patch-3 (9f11237) with main (8f61f9c)

Summary

✅ 7 untouched benchmarks

@saulshanabrook
Copy link
Member Author

It looks like this is the commit which codspeed symbol resolution stopped working: 73e5cb3

@saulshanabrook saulshanabrook merged commit b8be084 into main Jul 8, 2025
22 checks passed
@saulshanabrook saulshanabrook deleted the saulshanabrook-patch-3 branch July 8, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant