Skip to content

Change conversion between binary operators to consider converting both types #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 8, 2025

Conversation

saulshanabrook
Copy link
Member

This PR updates our Python dependencies and in the process:

  • Adds support for __round__
  • Changes the conversion to consider upcasting both the LHS and RHS when one is a Python value for binary operations
  • Adds ability to override __hash__ to allow simplifying first

Copy link

codspeed-hq bot commented Aug 8, 2025

CodSpeed Instrumentation Performance Report

Merging #320 will improve performances by 30.82%

Comparing upgrade-python (4d9340a) with main (5f8da71)

🎉 Hooray! pytest-codspeed just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 1 improvements
✅ 6 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_run_lda[array_api] 4.5 ms 3.4 ms +30.82%

@saulshanabrook saulshanabrook merged commit bbb4df8 into main Aug 8, 2025
5 checks passed
@saulshanabrook saulshanabrook deleted the upgrade-python branch August 8, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants