Skip to content

Add edm4eic::Jet #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add edm4eic::Jet #118

wants to merge 2 commits into from

Conversation

ruse-traveler
Copy link
Contributor

Briefly, what does this PR introduce?

Following the discussion in #88 , this PR introduces edm4eic::Jet. This type, inspired by the fastjet::PseudoJet, aims to represent jets in our data model in a more adequate way than edm4eic::ReconstructedParticle.

Note these 3 design choices:

  • Only edm4eic::ReconstructedParticle are allowed as constituents, which places jet reconstruction in the final stages of reconstruction,
  • No substructure quantities are represented in the type, which defers them to analyses,
  • And the one-to-many relation jets allows for either the indication of/connection to sub-jets, seed jets (which may be deployed in background-subtraction algorithms), or background jets (e.g. off-axis cones).

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@ruse-traveler ruse-traveler requested a review from a team as a code owner July 9, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants