-
Notifications
You must be signed in to change notification settings - Fork 1
Added branded emails for non html and GF Notifications #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add more comments tomorrow, but looking good so far. Just a few suggested changes.
@DanielHudson2 Looking great thanks! A few points (only minor):
The styling requirements might get more complicated, so perhaps we move styling to a class method and simply call the method in the email-styles.php file (probably return an array of the colour keys and values)? |
… and multi layer variables
…into feature/branded-emails
… setting email font
We are looking good now, thanks @DanielHudson2 🎉 |
orbit_branded_emails_disable
can be used to completely disable this featureorbit_branded_emails_header_logo
can be used to set a logo in the email header, if this isn't set then it falls back to a h1 containing the site nameemail-styles.php
for controlling colours in email e.g.orbit_branded_emails_background_color