Skip to content

Prefer showing the reaction button at small screen widths #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: livekit
Choose a base branch
from
Open

Prefer showing the reaction button at small screen widths #3400

wants to merge 8 commits into from
+262 −191

Conversation

robintown
Copy link
Member

@robintown robintown commented Jul 10, 2025 •
edited
Loading

⚠️ Based on #3336, review just the new commits
Closes #3272

@robintown robintown requested a review from a team as a code owner July 10, 2025 20:15
@robintown robintown added X-Blocked Cannot be merged due to external dependencies PR-Improvement Release note category. A PR that improves EC's performance or stability. labels Jul 10, 2025
@robintown robintown requested a review from BillCarsonFr July 10, 2025 20:15
@BillCarsonFr
Copy link
Member

⚠️ Based on #3336, review just the last commit

I usually let github handles that by selecting the base branch:
image

Like that the review is only the last commit. And when the dependency is merged this will change the base branch here automatically.

Any reason why you are doing differently?

BillCarsonFr
BillCarsonFr requested changes Jul 11, 2025
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could have a test for that?
I think we can test that with playwright await browser.newContext({ reducedMotion: "reduce", screen: {width: 340, height: 720} })?

@robintown robintown requested a review from BillCarsonFr August 14, 2025 19:51
@robintown
Copy link
Member Author

Test added.

@robintown robintown requested a review from toger5 August 15, 2025 12:21
@robintown robintown removed the X-Blocked Cannot be merged due to external dependencies label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr

@toger5 toger5 Awaiting requested review from toger5

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
PR-Improvement Release note category. A PR that improves EC's performance or stability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the reactions button available on small mobile screen width layouts
2 participants
@robintown @BillCarsonFr