Handle preference stores corruption by clearing them #5086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
PreferenceDataStoreFactory
instead ofpreferences by
.DefaultPreferencesCorruptionHandlerFactory.replaceWithEmpty
to itscreate(name)
method so all preference stores are cleared if they're corrupted.Motivation and context
Fix crash loops as soon as the app uses something that relies on a corrupted data store, forcing them to clear the data/reinstall the app. (https://sentry.tools.element.io/organizations/element/issues/11202491/events/7de4ded2ec3f47fc9b46de9aec4ac231/)
Tests
It's not easy to test unless you manually modify a data store so it's malformed next time you try to use it.
Tested devices
Checklist