Skip to content

Update Compose BOM to version 2025.08.00. #5179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 18, 2025

Content

Upgrade to latest compose version

Motivation and context

Be up to date

Screenshots / GIFs

Tests

  • No expected change, let see the screenshot test result.
  • Smoke test in progress OK

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Dependencies Pull requests that update a dependency file label Aug 18, 2025
@bmarty bmarty requested a review from a team as a code owner August 18, 2025 09:25
@bmarty bmarty requested review from jmartinesp and removed request for a team August 18, 2025 09:25
Copy link
Contributor

github-actions bot commented Aug 18, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nTJBEf

@ElementBot
Copy link
Collaborator

ElementBot commented Aug 18, 2025

Warnings
⚠️

gradle/libs.versions.toml#L7 - A newer version of org.jetbrains.kotlin.plugin.serialization than 2.2.0 is available: 2.2.10

⚠️

gradle/libs.versions.toml#L7 - A newer version of org.jetbrains.kotlin:compose-compiler-gradle-plugin than 2.2.0 is available: 2.2.10

⚠️

gradle/libs.versions.toml#L9 - A newer version of com.google.devtools.ksp:symbol-processing-api than 2.2.0-2.0.2 is available: 2.2.10-2.0.2

⚠️

gradle/libs.versions.toml#L178 - A newer version of org.matrix.rustcomponents:sdk-android than 25.8.5 is available: 25.8.18

Generated by 🚫 dangerJS against 4f79ff9

@jmartinesp
Copy link
Member

There seem to be some diffs in the screenshots, should we generate new ones?

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Aug 18, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Aug 18, 2025
@jmartinesp
Copy link
Member

jmartinesp commented Aug 18, 2025

It seems like this version broke all the dialog previews in screens using Scaffold 🫤 .

Copy link

@jmartinesp
Copy link
Member

I opened an issue in Paparazzi's repo: cashapp/paparazzi#2071, maybe it's Compose, maybe it's a combination of that and the alpha version.

@bmarty
Copy link
Member Author

bmarty commented Aug 18, 2025

It also seems to affect the preview in Android Studio, see for instance this hack, where the dialog is rendered only on the first preview:

image

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.22%. Comparing base (7c40c87) to head (4f79ff9).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ement/android/libraries/maplibre/compose/Symbol.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5179      +/-   ##
===========================================
- Coverage    80.23%   80.22%   -0.01%     
===========================================
  Files         2224     2224              
  Lines        60811    60809       -2     
  Branches      7701     7701              
===========================================
- Hits         48789    48787       -2     
  Misses        9215     9215              
  Partials      2807     2807              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp
Copy link
Member

jmartinesp commented Aug 19, 2025

It also seems to affect the preview in Android Studio, see for instance this hack, where the dialog is rendered only on the first preview:

I can reproduce it.

Maybe it's because of this commit? It's the latest one added to AndroidDialog.android.kt, and it affects the measured size of the dialog.


It started happening on 1.9.0-alpha01, so any of the changes added in that version could have caused it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants