Skip to content

Allow replying to any remote message in a thread #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jmartinesp
Copy link
Member

Content

Allow replying in a thread to any remote message. This will open the thread timeline screen and allow you to reply there, either adding a new message to the existing thread or starting a new one.

Motivation and context

Part of the thread v1 implementation.

Tests

  • Check the reply in thread action is displayed only for threaded events with the feature flag enabled.
  • With the feature flag enabled it's displayed for any remote event when not in the thread timeline, and it'll open the thread timeline screen.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

jmartinesp and others added 4 commits August 21, 2025 16:26
This will open the thread screen based on the selected event:

- If it was already part of a thread, it will open that thread.
- Otherwise, it'll open the thread timeline screen so you can start a thread from the event.
Also, rename the feature flag to something easier to understand.
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Aug 21, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Aug 21, 2025
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/so4Hzx

Copy link

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.20%. Comparing base (44d0111) to head (dc38254).

Files with missing lines Patch % Lines
...droid/libraries/matrix/impl/room/JoinedRustRoom.kt 0.00% 1 Missing ⚠️
...roid/libraries/matrix/impl/room/RustRoomFactory.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5201   +/-   ##
========================================
  Coverage    80.20%   80.20%           
========================================
  Files         2237     2237           
  Lines        61340    61353   +13     
  Branches      7769     7772    +3     
========================================
+ Hits         49197    49211   +14     
+ Misses        9300     9299    -1     
  Partials      2843     2843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants