[a11y] Add content descriptions to room list item indicators

[jmartinesp]

Content

What the title says. These can now be read aloud as 'ongoing call', 'new messages', 'new mentions'.

Motivation and context

Closes https://github.com/element-hq/customer-success/issues/573.

Tests

Enable a TTS solution like Talkback, then tap on different room list items/summaries.

• Tap on one without indicators: it should read just the room, timestamp and last message.
• Tap on one with an ongoing call: it should say also 'ongoing call'.
• Tap on one with mentions: it should say 'mentions', possible also 'new messages'.
• Tap on one with new messages: it should say 'new messages'.
• Tap on a muted one: it should say 'muted'.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Zdsp9V

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.21%. Comparing base (f4708a4) to head (991e0af).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #5236   +/-   ##
========================================
  Coverage    80.21%   80.21%           
========================================
  Files         2241     2241           
  Lines        61484    61491    +7     
  Branches      7791     7793    +2     
========================================
+ Hits         49319    49326    +7     
  Misses        9310     9310           
  Partials      2855     2855           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bmarty]

Thanks! 2 suggestions that may be handled later.

[bmarty]

UnreadIndicatorAtom is also used for invitation, so maybe let contentDescription be a parameter and add a string a11y_notifications_new_invitation?

[bmarty]

Maybe the indicator should be read first, and then the last message? It will require some change in the layout, but I believe that it will allow a faster screen reader navigation between rooms. We may handle this later though.

Note: happy to see that the a11y screenshot test is useful!

[jmartinesp]

Maybe I can play with the traversalIndex here, but something tells me it'll be harder than that 😅

[jmartinesp]

In the end I had to use zIndex again. It seems like traversalIndex won't work for nodes that merge their descendants.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud