Skip to content

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 27, 2025

Content

Now that we do not have the WaitList screen anymore, this interface and implementation are useless.

Motivation and context

Remove useless code.

Screenshots / GIFs

Tests

  • Perform a login flow. There should be no visible change.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

No that we do not have the WaitList screen anymore, this interface and implementation are useless.
@bmarty bmarty requested a review from a team as a code owner August 27, 2025 13:31
@bmarty bmarty added the PR-Misc For other changes label Aug 27, 2025
@bmarty bmarty requested review from jmartinesp and removed request for a team August 27, 2025 13:31
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/uD3cDo

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I can confirm the login flow works fine without this and it's always good to remove dead code!

Copy link

@bmarty bmarty enabled auto-merge August 27, 2025 13:42
@bmarty bmarty merged commit da03a50 into develop Aug 27, 2025
36 of 37 checks passed
@bmarty bmarty deleted the feature/bma/removeLoginUserStory branch August 27, 2025 13:44
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.21%. Comparing base (f4708a4) to head (1632706).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ent/android/appnav/root/RootNavStateFlowFactory.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5237      +/-   ##
===========================================
- Coverage    80.21%   80.21%   -0.01%     
===========================================
  Files         2241     2240       -1     
  Lines        61484    61471      -13     
  Branches      7791     7789       -2     
===========================================
- Hits         49319    49306      -13     
  Misses        9310     9310              
  Partials      2855     2855              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants