-
Notifications
You must be signed in to change notification settings - Fork 184
Add a Low Priority room filter behind a feature flag. #4394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@copilot There's a PR in the SDK now with the required filters: matrix-org/matrix-rust-sdk#5508 I'll integrate it in a bit, but you can update this PR in preparation. Unfortunately we needed 2 new filter types |
I've updated the implementation to prepare for the new
Ready for when you integrate the SDK update! (commit ea1f6b3) |
ea1f6b3
to
a08bb84
Compare
Co-authored-by: pixlwave <6060466+pixlwave@users.noreply.github.com>
bf29595
to
8eedd43
Compare
8eedd43
to
a69b221
Compare
// Apply active filters - the low priority exclusion logic will be handled | ||
// at the SDK level when the low priority filter is implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment feels unnecessary, perhaps we should name the app side filter better e.g. onlyLowPriority
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol oh yeah that one is very random, removing it.
I get what you're saying about the name, but technically they're all only
, e.g. onlyFavourites
, onlyRooms
etc so I'm not sure how much that would help. I think it's clear from the comment on .lowPriority
's rustFilter
value.
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
|
This PR implements a new "Low Priority" room filter (hidden behind a feature flag), with the key requirement that low priority rooms are hidden by default in the room list (when the flag is enabled).
Core Filter Implementation
lowPriority
case to theRoomListFilter
enumDefault Hiding Behavior
The implementation handles the new SDK filter architecture where:
NonLowPriority
filter will be included to hide low priority rooms by defaultLowPriority
filter to show only low priority roomsThis logic is implemented in
RoomSummaryProvider.setFilter()
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-13.at.10.31.16.mp4