Replace deprecated Gtk.ComboBox with Gtk.DropDown #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… model; Clean code;
|
Needs more testing on changing scale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #400
Closes #425
This PR introduces the following improvements:
DisplayWidgetandVirtualMonitor, resulting in a more modular and maintainable architecture.DisplayWidgetconstructor has been significantly simplified, focusing only on creating and connecting the new widgets.Gtk.ComboBoxand related data models have been fully replaced by the new dropdown widgets.FiltersViewnow usesVariant.maybefor more robust null value handling.Gtk.DropDowndoes not support tree hierarchies, all available resolutions are now presented in a single flat list in the resolutions dropdown.