Skip to content

Conversation

zmotso
Copy link
Member

@zmotso zmotso commented Nov 15, 2024

Pull Request Template

Description

Add setting adminUrl homeUrl for Client.

Fixes #106

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual testing

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@zmotso zmotso added the feature label Nov 15, 2024
@zmotso zmotso self-assigned this Nov 15, 2024
@zmotso zmotso requested a review from a team as a code owner November 15, 2024 09:59
@SergK SergK merged commit bf6b3af into master Nov 15, 2024
11 checks passed
@SergK SergK deleted the i/106 branch November 15, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add setting adminUrl rootUrl and baseUrl in clients
2 participants