Skip to content

Conversation

dougkirkley
Copy link
Contributor

Pull Request Template

Description

I needed the ability to use a client specific setup for browser and direct grant flows. This allows overriding those two auth flows on a client basis.

Fixes #116

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@dougkirkley dougkirkley requested review from zmotso and a team as code owners December 20, 2024 15:42
@dougkirkley dougkirkley force-pushed the feat/keycloak-client-auth-flows branch 2 times, most recently from 9ba7cc5 to 047a54b Compare December 20, 2024 16:07
@zmotso
Copy link
Member

zmotso commented Dec 23, 2024

/recheck

Copy link
Member

@zmotso zmotso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougkirkley Thank you for contribution.
Please fix a couple of comments, and we will merge your PR.

@dougkirkley dougkirkley force-pushed the feat/keycloak-client-auth-flows branch 2 times, most recently from defde95 to 92597b1 Compare December 23, 2024 15:12
Signed-off-by: Douglass Kirkley <doug.kirkley@gmail.com>
@dougkirkley dougkirkley force-pushed the feat/keycloak-client-auth-flows branch from e58f0fa to 1bd9fe6 Compare December 23, 2024 16:07
@dougkirkley dougkirkley requested a review from zmotso December 23, 2024 16:34
@zmotso
Copy link
Member

zmotso commented Dec 24, 2024

@SergK We can merge this PR.

Copy link
Member

@SergK SergK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougkirkley thank you for the contribution.
@zmotso thanks for the review

@SergK SergK merged commit bf4deb0 into epam:master Dec 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AuthenticationFlowBindingOverrides to Keycloak Client
3 participants