Skip to content

Conversation

dougkirkley
Copy link
Contributor

Pull Request Template

Description

Adds support for multiple values for a user attribute as well as backwards compatibility with the old string value

Fixes #194

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@dougkirkley dougkirkley force-pushed the feat/multi-value-attributes branch 4 times, most recently from 60ae72c to 369d067 Compare July 31, 2025 15:44
@dougkirkley dougkirkley marked this pull request as ready for review July 31, 2025 15:57
@dougkirkley dougkirkley requested review from zmotso and a team as code owners July 31, 2025 15:57
@dougkirkley dougkirkley force-pushed the feat/multi-value-attributes branch from 369d067 to 2f02ff8 Compare July 31, 2025 16:15
Copy link
Member

@zmotso zmotso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement. Please fix the comments, and we can proceed with merging.

@dougkirkley dougkirkley force-pushed the feat/multi-value-attributes branch 10 times, most recently from 25543b3 to b344ec5 Compare August 20, 2025 16:56
@dougkirkley
Copy link
Contributor Author

@zmotso This unfortunately stopped working now that I tried to update it, the k8s API isn't accepting both the string and slice values. If you have any ideas as to why that is happening now, let me know!

@dougkirkley dougkirkley force-pushed the feat/multi-value-attributes branch 4 times, most recently from 61def6b to 9b0a064 Compare August 27, 2025 11:11
@dougkirkley dougkirkley marked this pull request as draft August 27, 2025 16:01
@zmotso
Copy link
Member

zmotso commented Aug 27, 2025

Please check #205 (comment)

@dougkirkley dougkirkley force-pushed the feat/multi-value-attributes branch 3 times, most recently from 494a74f to a196c7a Compare August 28, 2025 12:50
@dougkirkley dougkirkley marked this pull request as ready for review August 28, 2025 12:51
@dougkirkley dougkirkley force-pushed the feat/multi-value-attributes branch 4 times, most recently from 1c975b4 to 1d2910a Compare August 28, 2025 13:42
Signed-off-by: Douglass Kirkley <doug.kirkley@gmail.com>
@dougkirkley dougkirkley force-pushed the feat/multi-value-attributes branch from 1d2910a to b5496e7 Compare August 28, 2025 15:05
@dougkirkley
Copy link
Contributor Author

@zmotso @MykolaMarusenko Do you think we can make a new release once this PR is merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for list of attributes with the same key
2 participants