-
Notifications
You must be signed in to change notification settings - Fork 27
feat: Add support for list of attributes with the same key #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
60ae72c
to
369d067
Compare
369d067
to
2f02ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement. Please fix the comments, and we can proceed with merging.
internal/controller/keycloakclientscope/keycloakclientscope_controller.go
Outdated
Show resolved
Hide resolved
25543b3
to
b344ec5
Compare
@zmotso This unfortunately stopped working now that I tried to update it, the k8s API isn't accepting both the string and slice values. If you have any ideas as to why that is happening now, let me know! |
61def6b
to
9b0a064
Compare
Please check #205 (comment) |
494a74f
to
a196c7a
Compare
1c975b4
to
1d2910a
Compare
Signed-off-by: Douglass Kirkley <doug.kirkley@gmail.com>
1d2910a
to
b5496e7
Compare
@zmotso @MykolaMarusenko Do you think we can make a new release once this PR is merged in? |
Pull Request Template
Description
Adds support for multiple values for a user attribute as well as backwards compatibility with the old string value
Fixes #194
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: