Skip to content

feat: Add ability to add Permissions to KeycloakRealmIdentityProvider #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

feat: Add ability to add Permissions to KeycloakRealmIdentityProvider #208

merged 1 commit into from
Aug 28, 2025
+864 −101

Conversation

dougkirkley
Copy link
Contributor

Pull Request Template

Description

Adds Admin fine grained permission to Identity Providers

Fixes #207

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

  • Manually
  • Integration tests

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@dougkirkley dougkirkley force-pushed the feat/idp-permissions branch 3 times, most recently from 4a4bff5 to e844c7a Compare August 26, 2025 22:11
@dougkirkley dougkirkley marked this pull request as ready for review August 26, 2025 22:19
@dougkirkley dougkirkley requested review from zmotso and a team as code owners August 26, 2025 22:19
@dougkirkley dougkirkley force-pushed the feat/idp-permissions branch from e844c7a to 848af30 Compare August 26, 2025 22:34
@dougkirkley
Copy link
Contributor Author

This PR is good, but an unrelated test is failing...

@dougkirkley dougkirkley force-pushed the feat/idp-permissions branch from 848af30 to d681ca5 Compare August 27, 2025 14:44
zmotso
zmotso requested changes Aug 28, 2025
View reviewed changes
Copy link
Member

@zmotso zmotso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code appears to be good; please fix one minor comment.

@zmotso
Copy link
Member

zmotso commented Aug 28, 2025

This PR is good, but an unrelated test is failing...

Sometimes integration tests may fail; try rerunning the GitHub action.

@dougkirkley
feat: Add ability to add Permissions to KeycloakRealmIdentityProvider
cf3de77 
Signed-off-by: Douglass Kirkley <doug.kirkley@gmail.com>
@dougkirkley dougkirkley force-pushed the feat/idp-permissions branch from d681ca5 to cf3de77 Compare August 28, 2025 11:06
@zmotso zmotso added the enhancement New feature or request label Aug 28, 2025
@zmotso
Copy link
Member

zmotso commented Aug 28, 2025

@MykolaMarusenko I've reviewed the PR. Please proceed with merging.

@MykolaMarusenko MykolaMarusenko merged commit aed0c7b into epam:master Aug 28, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmotso zmotso zmotso requested changes

@MykolaMarusenko MykolaMarusenko MykolaMarusenko approved these changes

Assignees

@dougkirkley dougkirkley

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to add Permissions to KeycloakRealmIdentityProvider
3 participants
@dougkirkley @zmotso @MykolaMarusenko