Skip to content

Conversation

dougkirkley
Copy link
Contributor

@dougkirkley dougkirkley commented Jul 24, 2024

Pull Request Template

Description

Please include a summary of the change and why it is needed.

Fixes #80

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contain one commit. I squash my commits

@zmotso
Copy link
Member

zmotso commented Jul 26, 2024

Hi @dougkirkley,

Thank you for opening this PR.

Could you please consolidate your changes into a single commit with the message: feat: Add displayHTMLName to realm resource (#80)?

Thank you!

@dougkirkley dougkirkley force-pushed the feat/realm-html-display-name branch from 4789d50 to 6f4fd53 Compare July 28, 2024 01:04
@dougkirkley dougkirkley marked this pull request as ready for review July 28, 2024 01:05
@dougkirkley dougkirkley requested review from zmotso and a team as code owners July 28, 2024 01:05
@dougkirkley dougkirkley force-pushed the feat/realm-html-display-name branch from 6f4fd53 to e81b543 Compare July 28, 2024 01:07
@dougkirkley dougkirkley force-pushed the feat/realm-html-display-name branch from e81b543 to aff6201 Compare July 28, 2024 01:24
@zmotso zmotso added the enhancement New feature or request label Jul 29, 2024
@zmotso
Copy link
Member

zmotso commented Jul 29, 2024

@SergK We can merge the PR.

@SergK SergK merged commit 7762f24 into epam:master Jul 29, 2024
10 checks passed
@SergK
Copy link
Member

SergK commented Jul 29, 2024

@dougkirkley, thank you for your contribution.

@dougkirkley dougkirkley deleted the feat/realm-html-display-name branch July 30, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add displayHTMLName to KeycloakRealm
3 participants