feat: Remove ownerReference from Keycloak resources #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting ownerReference with controller:true for Keycloak resources has disadvantages: - `controller: true` should be set for resources created by a controller. For example, we create a Deployment, and the controller creates a ReplicaSet with an `ownerReference` to the Deployment. In our case, we create resources separately, and the Keycloak controller isn't responsible for their creation. - ArgoCD doesn't remove resources with `controller: true`. It considers another controller responsible for them. If we remove the ArgoCD environment that contains KeycloakClient, this CR won't be removed by either ArgoCD or the Keycloak operator. This change breaks the automatic deletion of CRs if related Keycloak/KeycloakRealm is removed. Now, it isn't the responsibility of the keycloak operator.
|
postpone for now |
|
Implementation: #158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Setting ownerReference with controller:true for Keycloak resources has disadvantages:
controller: trueshould be set for resources created by a controller. For example, we create a Deployment, and the controller creates a ReplicaSet with anownerReferenceto the Deployment. In our case, we create resources separately, and the Keycloak controller isn't responsible for their creation.controller: true. It considers another controller responsible for them. If we remove the ArgoCD environment that contains KeycloakClient, this CR won't be removed by either ArgoCD or the Keycloak operator.This change breaks the automatic deletion of CRs if related Keycloak/KeycloakRealm is removed.
Now, it isn't the responsibility of the keycloak operator.
Fixes #71
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: