Add support for optional client scopes

[fleskesvor]

Pull Request Template

Description

The change adds support for optional client scopes. This is required because it's a common use-case to only add certain claims on explicitly requested scopes.

I couldn't find any issues that requested this feature.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I've built and deployed this in a local kind cluster, and tested by adding clients with both default and optional scopes. Additionally, I've added two unit tests, which might be on the short side coverage wise, but I'll gladly improve on this, if wanted.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Pull Request contain one commit. I squash my commits

[fleskesvor]

The build pipeline doesn't load for me, so I'm not sure what's failing. Might be the e2e tests though, because I haven't run those locally yet, so I'll look into that.

EDIT: When run locally, the e2e tests fail on trying to pull quay.io/keycloak/keycloak:24.0.2 and timing out. However, I'm able to pull the image with Docker locally, so I'm thinking it might be an issue with crictl and that specific registry inside kind. 🤔

[fleskesvor]

@zmotso I'm still unable to open the Tekton CI page to investigate what's failing there. Could you please help me understand what needs to be fixed for this PR to be reviewed?

[SergK]

/recheck

[SergK]

Hi @fleskesvor, let me check - since quality gates from GitHub are enough for CI.

[zmotso]

Hi @fleskesvor,

Thanks for the PR! The code looks good, and I have no additional comments.

@SergK, please proceed with merging this PR when ready.

[SergK]

@fleskesvor Thank you

[fleskesvor]

Thank you both! ❤️