-
-
Notifications
You must be signed in to change notification settings - Fork 4
v0.8.0 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensures that data_format is always long for data.table output - added test for check_data_format
by reading entire block into memory at once.
…tributes by reading entire block into memory at once. - also fixed data_format attribute for `MS1` data.
- use `format_2d_chromatogram` - use check_data_format - fix MS1 data_format attribute - collapse at the end
- use check_data_format function - allow formating of TIC - fixed `data_format` attribute for `MS1` data - fixed docs to reflect `data_format` changes
- use `check_data_format` and `check_format_out` functions - pass `data_format` argument to `read_mzml`
- also more tests for Shimadzu timezone conversions - split long lines
to configure a dedicated chromConverter virtual environment or conda environment (though this is no longer required with the latest versions of reticulate).
- remove weird indexing - remove failing time test (entab timezone seems to be wrong)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chromConverter 0.8.0
.dx
files: extraction of DAD and auxiliary instrumental data (stored in.IT
files).read_shimadzu_qgd
for a 1.4x speedup in the parsing of Shimadzu.qgd
files, cutting execution time by 30%.read_shimadzu_lcd
for a 2.4x speedup in the parsing of Shimadzu.lcd
files, cutting execution time by 60%.write_mzml
for massive speed-up when writing mzML files, especially for large MS data.read_agilent_d
causing possible bug.read_chemstation_uv
causing error for long format data.read_agilent_d
.data_format
attribute.data_format
andread_metadata
arguments forread_chemstation_csv
.data_format
attributes for MS data to reflect that they are always returned in long format.data.table
output is selected since data.tables do not have rownames.write_mzml
causing retention time shifts for BPC and TIC.configure_python_environment
function to facilitate configuration of a chromConverter virtual environment or conda environment, though a dedicated environment is no longer required (as of chromConverter v0.7.4).